ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Madhan Neethiraj" <mad...@apache.org>
Subject Re: Review Request 40837: Ranger-755, Ranger-756, Ranger-757: Ldap tool fails with different command line options.
Date Tue, 01 Dec 2015 21:25:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40837/#review108560
-----------------------------------------------------------



ugsync/ldapconfigchecktool/ldapconfigcheck/scripts/run.sh (line 36)
<https://reviews.apache.org/r/40837/#comment168012>

    "noauthh" ==" "a:h"



ugsync/ldapconfigchecktool/ldapconfigcheck/src/main/java/org/apache/ranger/ldapconfigcheck/CommandLineOptions.java
(line 75)
<https://reviews.apache.org/r/40837/#comment168013>

    This change would result in "r" option (retrieve) be ignored when "d" option (discoverProperties)
is specified. Is this intentional?


- Madhan Neethiraj


On Dec. 1, 2015, 8:59 p.m., Sailaja Polavarapu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40837/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2015, 8:59 p.m.)
> 
> 
> Review request for ranger, Alok Lal, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, and
Velmurugan Periasamy.
> 
> 
> Bugs: Ranger-755, Ranger-756 and Ranger-757
>     https://issues.apache.org/jira/browse/Ranger-755
>     https://issues.apache.org/jira/browse/Ranger-756
>     https://issues.apache.org/jira/browse/Ranger-757
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> "getopts" function in shell script reads the command line options one character at a
time. Hence -noauth is treated as -n, -o, -a, etc... which is the root cause for Ranger-755.
> For Ranger-756 & Ranger-757: According to the original design of ldap tool, verification
of authentication is intended to be performed only while discovering all the usersync properties.
Some of the conditions to disable auth verification were not handled properly.
> 
> 
> Diffs
> -----
> 
>   ugsync/ldapconfigchecktool/ldapconfigcheck/scripts/run.sh 787e216 
>   ugsync/ldapconfigchecktool/ldapconfigcheck/src/main/java/org/apache/ranger/ldapconfigcheck/CommandLineOptions.java
790330f 
> 
> Diff: https://reviews.apache.org/r/40837/diff/
> 
> 
> Testing
> -------
> 
> 1. Tested various combinations on the command line arguments and verified the desired
results.
> 2. Also tested with both dev & QE setup to run different tests for regressions.
> 
> 
> Thanks,
> 
> Sailaja Polavarapu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message