ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Madhan Neethiraj" <mad...@apache.org>
Subject Re: Review Request 40859: Ranger 754 : Ranger YARN Plugin lookup and test connection should support SPENGO enabled HTTP Authentication
Date Wed, 02 Dec 2015 16:48:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40859/#review108658
-----------------------------------------------------------

Ship it!


Please review the comments and update.


agents-common/src/main/java/org/apache/ranger/plugin/client/HadoopConfigHolder.java (line
58)
<https://reviews.apache.org/r/40859/#comment168120>

    isHadoopHTTPAuthentication does not seem to be used. Please review and remove if not necessary.



plugin-yarn/src/main/java/org/apache/ranger/services/yarn/client/YarnClient.java (line 73)
<https://reviews.apache.org/r/40859/#comment168121>

    Consider the following log messages:
    "no value found for configuration 'yarn.url'. YARN resource lookup will fail"
    
    "no value found for configuration 'username'. YARN resource lookup might fail"
    
    "no value found for configuration 'password'. YARN resource lookup might fail"



plugin-yarn/src/main/java/org/apache/ranger/services/yarn/client/YarnClient.java (line 74)
<https://reviews.apache.org/r/40859/#comment168122>

    Consider removing "else"; so that all necessary configuration will be tested and logged,
if empty.



plugin-yarn/src/main/java/org/apache/ranger/services/yarn/client/YarnClient.java (line 326)
<https://reviews.apache.org/r/40859/#comment168123>

    YarnLookupAuthenticator does not seem to be used. Please review and remove if not necessary.


- Madhan Neethiraj


On Dec. 2, 2015, 8:38 a.m., Ramesh Mani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40859/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2015, 8:38 a.m.)
> 
> 
> Review request for ranger and Madhan Neethiraj.
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Ranger 754 : Ranger YARN Plugin lookup and test connection should support SPENGO enabled
HTTP Authentication
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/client/HadoopConfigHolder.java
f95e10e 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-yarn.json ff1f39f 
>   plugin-yarn/src/main/java/org/apache/ranger/services/yarn/client/YarnClient.java fc07760

>   plugin-yarn/src/main/java/org/apache/ranger/services/yarn/client/YarnConnectionMgr.java
e2cc2ef 
>   plugin-yarn/src/main/java/org/apache/ranger/services/yarn/client/YarnResourceMgr.java
95d29c0 
> 
> Diff: https://reviews.apache.org/r/40859/diff/
> 
> 
> Testing
> -------
> 
> Configure the hadoop for  http Authenticaton https://hadoop.apache.org/docs/r1.2.1/HttpAuthentication.html
> 
> Verified Ranger Yarn Service Test connection successful in the Ranger Admin UI
> Verified Ranger Yarn Service Lookup fetching the yarn resources in Ranger Admin UI
> Verified the same without HTTP authentication in a cluster and secure cluster.
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message