ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gautam Borad" <gbo...@gmail.com>
Subject Re: Review Request 40868: RANGER-761 : Transaction logs not getting generated under audit menu admin tab if policy name is changed
Date Thu, 03 Dec 2015 05:40:52 GMT


> On Dec. 2, 2015, 5:26 p.m., Madhan Neethiraj wrote:
> > security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java,
line 384
> > <https://reviews.apache.org/r/40868/diff/1/?file=1150545#file1150545line384>
> >
> >     Consider replcing this method body with the following:
> >       return org.apache.commons.lang.StringUtils.equals(value, oldValue);

Tested again with suggested changes and it is working as expected.


- Gautam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40868/#review108677
-----------------------------------------------------------


On Dec. 2, 2015, 2:13 p.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40868/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2015, 2:13 p.m.)
> 
> 
> Review request for ranger, Alok Lal, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj,
Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-761
>     https://issues.apache.org/jira/browse/RANGER-761
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> **Current Issue :**
> 
> Transaction logs not getting generated under audit menu admin tab if policy name is changed
> 
> ** Proposed Solution : **
> In every policy update event, will compare policy old name and new name, if there is
difference in old name and new name then will log the update event in x_trx_log table with
old policy name and new policy name.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java d853972

> 
> Diff: https://reviews.apache.org/r/40868/diff/
> 
> 
> Testing
> -------
> 
> **Steps Performed(with patch) :**
> 1. Created a hdfs policy(mypolicy1) under hadoopdev service.
> 2. Visited audit menu, audit tab and checked create policy log. Create policy log was
there.
> 3. Visited policy manager and then hadoopdev service and then clicked on edit button
of created policy in step 1(mypolicy1).
> 4. Changed the name of policy from 'mypolicy1' to 'mypolicy1new'
> 5. Visited audit menu, audit tab to check new logs related to 'mypolicy1'
> 
> 
> **Result/Behavior:**
> Update policy log was generated and seen.
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message