ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "dilli dorai" <dillido...@apache.org>
Subject Re: Review Request 41080: RANGER-773 : Fix newly found Coverity scan issues for Ranger KMS
Date Tue, 08 Dec 2015 17:08:16 GMT


> On Dec. 8, 2015, 4:12 p.m., Madhan Neethiraj wrote:
> > kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java, line 185
> > <https://reviews.apache.org/r/41080/diff/1/?file=1155854#file1155854line185>
> >
> >     Please review addKeyEntry() for a similar breakup of synchronized block:
> >              synchronized(deltaEntries) {
> >                     ...
> >                     deltaEntries.put(alias.toLowerCase(), entry);   
> >                     keyEntries.put(alias.toLowerCase(), entry);    
> >              }
> 
> dilli dorai wrote:
>     What were the issues reported by coverity?
>     Without knowing that, how does one review the code?

You could ignore the comment, JIRAS has some details


- dilli


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41080/#review109336
-----------------------------------------------------------


On Dec. 8, 2015, 7:36 a.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41080/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2015, 7:36 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj,
Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-773
>     https://issues.apache.org/jira/browse/RANGER-773
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Patch contains fixes for issues found by coverity scan in Ranger KMS
> 
> 
> Diffs
> -----
> 
>   kms/src/main/java/org/apache/hadoop/crypto/key/Ranger2JKSUtil.java 0def5e5 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java 850104f 
> 
> Diff: https://reviews.apache.org/r/41080/diff/
> 
> 
> Testing
> -------
> 
> Tested for KMS scenarios related to CRUD operation for key and is working fine.
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message