ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Madhan Neethiraj" <mad...@apache.org>
Subject Re: Review Request 41967: Good coding practice: fix issues in updates from RANGER-794
Date Thu, 07 Jan 2016 01:22:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41967/#review113158
-----------------------------------------------------------

Ship it!



agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerFileBasedTagRetriever.java
(line 105)
<https://reviews.apache.org/r/41967/#comment173658>

    Consider moving GsonBuilder() instantiation outside this if block - perhaps at the begining
of the init().
    
    Also "serviceTagsFileURL != null" can be removed, as the code inside this block does not
refer to serviceTagsFileURL.


- Madhan Neethiraj


On Jan. 7, 2016, 12:07 a.m., Abhay Kulkarni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41967/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2016, 12:07 a.m.)
> 
> 
> Review request for ranger and Madhan Neethiraj.
> 
> 
> Bugs: RANGER-796
>     https://issues.apache.org/jira/browse/RANGER-796
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Good coding practice: fix issues in updates from RANGER-794 uncovered by static analysis
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerFileBasedTagRetriever.java
95291be 
>   agents-common/src/main/java/org/apache/ranger/plugin/store/AbstractPredicateUtil.java
62b9bca 
>   agents-common/src/main/java/org/apache/ranger/plugin/util/PerfDataRecorder.java 72da8e8

>   ranger-tools/src/main/java/org/apache/ranger/policyengine/CommandLineParser.java a45d71a

>   ranger-tools/src/main/java/org/apache/ranger/policyengine/PerfTestClient.java b88d670

>   ranger-tools/src/main/java/org/apache/ranger/policyengine/PerfTestEngine.java 1b5f6fd

>   ranger-tools/src/main/java/org/apache/ranger/policyengine/RangerPolicyenginePerfTester.java
28cc558 
> 
> Diff: https://reviews.apache.org/r/41967/diff/
> 
> 
> Testing
> -------
> 
> Ran ranger-engine test tool and checked that the results were as expected.
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message