ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alok Lal" <a...@hortonworks.com>
Subject Re: Review Request 42063: Enable tagsync to run in secure mode
Date Mon, 11 Jan 2016 08:54:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42063/
-----------------------------------------------------------

(Updated Jan. 11, 2016, 12:54 a.m.)


Review request for ranger, Abhay Kulkarni and Madhan Neethiraj.


Changes
-------

Main Changes done in this patch
- Used hadoop configuration library to read values from site.xml for jass file name.
- Installer will put some files in startup/lib (similar to install/lib).  This has classes
that startup script uses to get the jass filename.
- Added slf4j-log4j12 dependency to tagsync and version info to main pom.  This was needed
to help diagnoses auth and connection problems in zookeeper and kafka code inside Atlas client
code.
- Still on same version so diff is easy to see.  I have applied this on master and it applies
cleanly, I'll use that to push.

Testing done:
Tagsync is able to connect to standalone Kafka queue, verified that the consumer for group
shows up.  Haven't actually gotten Atlas messages to be consumed yet.  But that is does not
seem to be a security related issue.


Bugs: RANGER-801
    https://issues.apache.org/jira/browse/RANGER-801


Repository: ranger


Description
-------

Enable tagsync to run in secure mode.  Please ignore prior review request for this change.
- Since kafka clients only work with jass files, this change does authentication only using
jass files.  Thanks @Abhay for that feedback during my offline discussion.
- service command passes the jass file argument during startup.


Diffs (updated)
-----

  agents-installer/pom.xml 633da6d 
  agents-installer/src/main/java/org/apache/ranger/utils/install/ConfigPropertyReader.java
PRE-CREATION 
  pom.xml d3a7a99 
  src/main/assembly/tagsync.xml 8adc5cc 
  tagsync/conf.dist/ranger-tagsync-env-setup-hadoop-home.sh c171d2a 
  tagsync/conf/templates/installprop2xml.properties 101a1ba 
  tagsync/conf/templates/ranger-tagsync-template.xml 9a88681 
  tagsync/scripts/install.properties b5ad580 
  tagsync/scripts/ranger-tagsync-services.sh ca82ead 
  tagsync/scripts/setup.py f7455b8 
  tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncConfig.java e1b5130 
  tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSynchronizer.java 7bae973 

Diff: https://reviews.apache.org/r/42063/diff/


Testing
-------

- Modified the tagsync code by hand to write to hdfs in a secure cluster.
- Current junits all work.


Thanks,

Alok Lal


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message