ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Madhan Neethiraj" <mad...@apache.org>
Subject Re: Review Request 42192: RANGER-810 : Audit page should show most recent audit log at the top
Date Tue, 12 Jan 2016 15:05:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42192/#review113996
-----------------------------------------------------------

Ship it!


Ship It!

- Madhan Neethiraj


On Jan. 12, 2016, 1:36 p.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42192/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2016, 1:36 p.m.)
> 
> 
> Review request for ranger, Alok Lal, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj,
Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-810
>     https://issues.apache.org/jira/browse/RANGER-810
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Problem Statement : 
> On selecting the Audit tab, the audit logs are listed in ascending order of audit event
time - showing the oldest log at the top. 
> 
> As part of changes added in RANGER-733, we removed using custom sort orders and started
taking only the default sort orders defined in super classes (in XAccessAuditService.java).
Because of which, sort order which was getting set in XAccessAuditService.java to eventTime
is now set to default field (id), and from UI side, we were not fetching the collection by
setting any sort order. Because of this, we are seeing audit logs ordered by Id not eventTime.

> 
> 
> Proposed Solution :
> Earlier we did not send sortBy parameter in request while fetching the collection. Now,
we are sending the sortBy=eventTime  parameter with request for fetching the Audit Acess collection.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/webapp/scripts/controllers/Controller.js 7b9cc39 
> 
> Diff: https://reviews.apache.org/r/42192/diff/
> 
> 
> Testing
> -------
> 
> Tested for :
> 
> 1) Sorting of Audit Access Logs on first load 
> 2) Default sort order, when we click on Refresh icon
> 3) Default sort order, after switching the Tab
> 
> Observation : 
> 
> It retained the sortBy parameter and shows the latest logs on top.
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message