ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Madhan Neethiraj" <mad...@apache.org>
Subject Re: Review Request 42219: RANGER-813 Script to install Solr for Ranger Audits doesn't work in Suse
Date Wed, 13 Jan 2016 16:40:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42219/#review114220
-----------------------------------------------------------



security-admin/contrib/solr_for_audit_setup/setup.sh (line 128)
<https://reviews.apache.org/r/42219/#comment175035>

    Consider moving 'if' in line #128 to outside the 'while' in line #126. In case "is_root
!= 1", the 'while' loop does nothing but iterate up to root folder name/



security-admin/contrib/solr_for_audit_setup/setup.sh (line 132)
<https://reviews.apache.org/r/42219/#comment175037>

    Many installation steps are already executed by this time. Should the installation abort
due to permission issue - without any cleanup? Consider the following options:
     - continue the installtion after giving warning about each incorrect permission folder
found (so that the user can manually update the permission)
     - prompt the user to accept the permission update and have the script update the permission


- Madhan Neethiraj


On Jan. 13, 2016, 3:33 a.m., Don Bosco Durai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42219/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2016, 3:33 a.m.)
> 
> 
> Review request for ranger and Madhan Neethiraj.
> 
> 
> Bugs: RANGER-813
>     https://issues.apache.org/jira/browse/RANGER-813
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Using low level useradd command instead of convienince script adduser.
> 
> 
> Diffs
> -----
> 
>   security-admin/contrib/solr_for_audit_setup/setup.sh 2ca1e6d 
> 
> Diff: https://reviews.apache.org/r/42219/diff/
> 
> 
> Testing
> -------
> 
> Manually tested installing Solr on Suse
> 
> 
> Thanks,
> 
> Don Bosco Durai
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message