ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 42954: RANGER-789 : Incorrect policy list paging for non-admin users - ranger-0.5 branch
Date Fri, 29 Jan 2016 16:02:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42954/#review116956
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On Jan. 29, 2016, 12:23 p.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42954/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2016, 12:23 p.m.)
> 
> 
> Review request for ranger, Alok Lal, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Ramesh
Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-789
>     https://issues.apache.org/jira/browse/RANGER-789
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Policy retrieval is updated to fix the incorrect policy list for non-admin users
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/store/AbstractPredicateUtil.java
772c2d7 
>   agents-common/src/main/java/org/apache/ranger/plugin/util/SearchFilter.java 17738be

>   security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 278ebc0 
>   security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java 897ed5d

>   security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 7718078 
>   security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java 8b3e348 
> 
> Diff: https://reviews.apache.org/r/42954/diff/
> 
> 
> Testing
> -------
> 
> Verified that policy list paging works correctly for non-admin users as well, by doing
the following:
>  - created large number of policies, say 1000
>  - every 20th policy had delgated-admin access for a non-admin user - user1
>  - login as user1 and view the policies
>  - verified that the first page shows full list of policies that user1 has delegated-admin
access to; before this fix, the first page would list only 2 policies
>  - verified that there is no change to policy listing for admin users
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message