ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Velmurugan Periasamy <vperias...@hortonworks.com>
Subject Re: Review Request 43376: Ranger-840: ranger-admin and ranger-usersync does not honour the SSL truststore property
Date Mon, 15 Feb 2016 16:59:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43376/#review119223
-----------------------------------------------------------


Fix it, then Ship it!




Fix and ship it!


ugsync/src/main/java/org/apache/ranger/ldapusersync/process/CustomSSLSocketFactory.java (line
1)
<https://reviews.apache.org/r/43376/#comment180494>

    Needs Apache license headers.


- Velmurugan Periasamy


On Feb. 9, 2016, 9:42 p.m., Sailaja Polavarapu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43376/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2016, 9:42 p.m.)
> 
> 
> Review request for ranger, Alok Lal, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj,
Ramesh Mani, and Velmurugan Periasamy.
> 
> 
> Bugs: Ranger-840
>     https://issues.apache.org/jira/browse/Ranger-840
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Added support for ranger usersync and ranger admin to use configured custom truststore
for LDAPS connectivity.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/common/PropertiesUtil.java 5229fe7 
>   ugsync/src/main/java/org/apache/ranger/ldapusersync/process/CustomSSLSocketFactory.java
PRE-CREATION 
>   ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapUserGroupBuilder.java
99403d7 
> 
> Diff: https://reviews.apache.org/r/43376/diff/
> 
> 
> Testing
> -------
> 
> 1. Tested usersync & ranger admin with and without custom truststore for LDAPS connectivity.
> 2. Tested with default truststore for regression cases
> 3. Ran some negative tests like invalid rootca, empty truststore, etc... for usersync
as well as ranger admin.
> 4. For ranger admin, added the truststore properties as part of custom properties for
validation.
> 
> 
> Thanks,
> 
> Sailaja Polavarapu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message