ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 43687: RANGER-838 : Tag-sync should be resilient to Ranger Admin availability
Date Wed, 24 Feb 2016 19:02:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43687/#review120508
-----------------------------------------------------------




tagsync/src/main/java/org/apache/ranger/tagsync/model/AbstractTagSource.java (line 66)
<https://reviews.apache.org/r/43687/#comment181977>

    I think it will be simpler and better abstraction to use UploadWorkItem to wait for upload
to complete - with addition of following methods:
     - UploadWorkItem.waitForUpload()
     - UploadWorkItem.uploadCompleted()
    
    This will replace the following members: 
     - AbstractTagSource.resume()
     - AbstractTagSource.uploadedServiceTags


- Madhan Neethiraj


On Feb. 24, 2016, 5:48 a.m., Abhay Kulkarni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43687/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2016, 5:48 a.m.)
> 
> 
> Review request for ranger, Alok Lal and Madhan Neethiraj.
> 
> 
> Bugs: RANGER-838
>     https://issues.apache.org/jira/browse/RANGER-838
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> RANGER-838 : Tag-sync should be resilient to Ranger Admin availability
> 
> 
> Diffs
> -----
> 
>   tagsync/src/main/java/org/apache/ranger/tagsync/model/AbstractTagSource.java d6baeb2

>   tagsync/src/main/java/org/apache/ranger/tagsync/model/TagSink.java 9eb5319 
>   tagsync/src/main/java/org/apache/ranger/tagsync/model/TagSource.java 7d19562 
>   tagsync/src/main/java/org/apache/ranger/tagsync/model/UploadWorkItem.java PRE-CREATION

>   tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncConfig.java ed8679a

>   tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSynchronizer.java 696ce5e

>   tagsync/src/main/java/org/apache/ranger/tagsync/sink/tagadmin/TagAdminRESTSink.java
1541034 
>   tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasTagSource.java 2499177

>   tagsync/src/main/java/org/apache/ranger/tagsync/source/atlasrest/AtlasRESTTagSource.java
9d9f25d 
>   tagsync/src/main/java/org/apache/ranger/tagsync/source/atlasrest/AtlasRESTUtil.java
7f4676a 
>   tagsync/src/main/java/org/apache/ranger/tagsync/source/file/FileTagSource.java e339d5e

> 
> Diff: https://reviews.apache.org/r/43687/diff/
> 
> 
> Testing
> -------
> 
> Tested by killing Ranger-Admin, Kafka, Atlas when ranger-admin was running
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message