ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alok Lal (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (RANGER-845) Replace StringBuffer with StringBuilder
Date Mon, 22 Feb 2016 17:14:18 GMT

    [ https://issues.apache.org/jira/browse/RANGER-845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15157303#comment-15157303
] 

Alok Lal commented on RANGER-845:
---------------------------------

Interesting.  {{git am}} seems to throw away anything in brackets in subject.  So the message
post am was " - Replace StringBuffer with StringBuilder".  Your point is taken though.  

{code}
>From 3e006d4418d38f2915e24b81a2cd1ae16acaa5b9 Mon Sep 17 00:00:00 2001
From: Colm O hEigeartaigh <coheigea@apache.org>
Date: Fri, 12 Feb 2016 14:45:49 +0000
Subject: [PATCH 1/1] [RANGER-845] - Replace StringBuffer with StringBuilder

---
 .../plugin/policyevaluator/RangerDefaultPolicyEvaluator.java      | 2 +-
 .../policyresourcematcher/RangerDefaultPolicyResourceMatcher.java | 2 +-
 .../src/main/java/org/apache/ranger/credentialapi/buildks.java    | 2 +-
 .../java/org/apache/util/outputformatter/DefaultFormatter.java    | 6 +++---
{code}

Perhaps the guideline should be "..please don't nestle the JIRA# in brackets in the commit
message!" ;)  Cheers!

> Replace StringBuffer with StringBuilder
> ---------------------------------------
>
>                 Key: RANGER-845
>                 URL: https://issues.apache.org/jira/browse/RANGER-845
>             Project: Ranger
>          Issue Type: Improvement
>            Reporter: Colm O hEigeartaigh
>            Assignee: Colm O hEigeartaigh
>            Priority: Trivial
>         Attachments: 0001-RANGER-845-Replace-StringBuffer-with-StringBuilder.patch
>
>
> StringBuffer should be replaced in the code by StringBuilder wherever possible, for performance
reasons.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message