ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gautam Borad <gbo...@gmail.com>
Subject Re: Review Request 43870: RANGER-859 : Allow user to define custom log directory during Ranger installation
Date Wed, 23 Mar 2016 08:50:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43870/
-----------------------------------------------------------

(Updated March 23, 2016, 8:50 a.m.)


Review request for ranger, Alok Lal, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Ramesh
Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.


Changes
-------

Updated patch takes care of Madhan's comments.


Bugs: RANGER-859
    https://issues.apache.org/jira/browse/RANGER-859


Repository: ranger


Description
-------

**Problem Statement : **
Ranger installation sets the log dir to '/var/log/ranger' (it is hardcoded as of now).
Need to allow user to define log dir in a property and use that property as log dir during
Ranger installation.

**Proposed Solution : **
These properties will be used by setup.sh to generate log dir and set user / group permissions
for log dir and also service start / stop scripts will use it to write the logs to that dir.


Diffs (updated)
-----

  embeddedwebserver/scripts/ranger-admin-services.sh 880ff49 
  embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java 14e339f

  kms/scripts/install.properties cf5dd92 
  kms/scripts/ranger-kms dfde6d5 
  kms/scripts/setup.sh 0a825c7 
  security-admin/scripts/install.properties cb10769 
  security-admin/scripts/setup.sh ce08686 
  unixauthservice/scripts/ranger-usersync-services.sh 4b3d4d4 
  unixauthservice/scripts/setup.py fface25 

Diff: https://reviews.apache.org/r/43870/diff/


Testing
-------

**Tested following scenarios : **


1) Installed Ranger / Ranger KMS manually and provided non existent path as log dir.
>> Setup script creates the new log dir with respective service user and logs are getting
geneated in provided log dir. 

2) Installed Ranger / Ranger KMS manually and provided existing path as log dir. 
>> Setup script changes user of log dir to service user and starts generating logs in
that dir.


Thanks,

Gautam Borad


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message