ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 45512: RANGER:904 : Update create-policy REST API to support override values via query parameters
Date Wed, 30 Mar 2016 23:59:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45512/#review126225
-----------------------------------------------------------




security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java (line 1008)
<https://reviews.apache.org/r/45512/#comment189134>

    this comment seems inaccurate. Consider removing it.



security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java (line 1023)
<https://reviews.apache.org/r/45512/#comment189135>

    Please remove "==>" from this log message.


- Madhan Neethiraj


On March 30, 2016, 11:52 p.m., Ramesh Mani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45512/
> -----------------------------------------------------------
> 
> (Updated March 30, 2016, 11:52 p.m.)
> 
> 
> Review request for ranger, Gautam Borad, Madhan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> RANGER:904 : Update create-policy REST API to support override values via query parameters
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/util/SearchFilter.java 25d69f0

>   security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java 827a69a 
>   security-admin/src/main/java/org/apache/ranger/rest/PublicAPIs.java ae407f1 
>   security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java 8601b95 
>   security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java e1aef0b 
>   security-admin/src/main/java/org/apache/ranger/service/RangerPolicyServiceBase.java
1195a50 
>   security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java 2be9441 
>   security-admin/src/test/java/org/apache/ranger/rest/TestServiceRESTForValidation.java
c591750 
> 
> Diff: https://reviews.apache.org/r/45512/diff/
> 
> 
> Testing
> -------
> 
> - Create Policy via public api
> curl -ivl -u admin:admin  -H "Content-Type: application/json" -X POST 'http://localhost:6080/service/public/v2/api/policy?serviceName=cl1_hadoop_DR&policyName=dr_policy_1&updateIfExists=true'
-d @create_policy.json
>  - Change these query params for creating policy against different Service NAme and Policy
Name
>  - Ran Internal System tests
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message