ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colm O hEigeartaigh (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (RANGER-871) Fix migrating issues
Date Fri, 04 Mar 2016 10:43:40 GMT

    [ https://issues.apache.org/jira/browse/RANGER-871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15179714#comment-15179714
] 

Colm O hEigeartaigh commented on RANGER-871:
--------------------------------------------

Here is the review request: https://reviews.apache.org/r/44384/

Yes, renaming testConnection() -> connectionTest() was due to the "JUnit4TestShouldUseTestAnnotation"
rule. It mistakenly thinks that anything starting with "test" is an actual test, as this was
how junit used to work. I have removed those changes from the patch for now. Would you like
me to submit a separate patch with these changes, or would you prefer to just keep the PMD
exclusion?

Thanks,

Colm.

> Fix migrating issues
> --------------------
>
>                 Key: RANGER-871
>                 URL: https://issues.apache.org/jira/browse/RANGER-871
>             Project: Ranger
>          Issue Type: Sub-task
>            Reporter: Colm O hEigeartaigh
>             Fix For: 0.6.0
>
>         Attachments: 0001-RANGER-871-Fix-Migrating-issues.patch
>
>
> Fix migrating issues



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message