ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 47015: RANGER-969 Correcting mis-spelling of delimiter in UserGroupSyncConfig
Date Thu, 05 May 2016 15:55:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47015/#review131842
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On May 5, 2016, 2:11 p.m., Bryan Bende wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47015/
> -----------------------------------------------------------
> 
> (Updated May 5, 2016, 2:11 p.m.)
> 
> 
> Review request for ranger, Don Bosco Durai and Madhan Neethiraj.
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> UserGroupSyncConfig had ranger.usersync.filesource.text.delimiterer but the Wiki page
said to use ranger.usersync.filesource.text.delimiter.
> 
> Updated the code to first look for ranger.usersync.filesource.text.delimiter, if nothing
is found then look for ranger.usersync.filesource.text.delimiterer, if nothing still found
then use the default value.
> 
> 
> Diffs
> -----
> 
>   ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java
9321e6e 
> 
> Diff: https://reviews.apache.org/r/47015/diff/
> 
> 
> Testing
> -------
> 
> Full build passes, tested running the user group sync with both property values and verified
users were loaded correctly from a file.
> 
> 
> Thanks,
> 
> Bryan Bende
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message