ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Velmurugan Periasamy <vperias...@hortonworks.com>
Subject Re: Review Request 47033: RANGER-970 Add Ability to transform user/group names when using file source
Date Mon, 09 May 2016 12:19:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47033/#review132258
-----------------------------------------------------------


Ship it!




Ship It!

- Velmurugan Periasamy


On May 5, 2016, 7 p.m., Bryan Bende wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47033/
> -----------------------------------------------------------
> 
> (Updated May 5, 2016, 7 p.m.)
> 
> 
> Review request for ranger, Don Bosco Durai and Madhan Neethiraj.
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Created an AbstractUserGroupSource and moved mappers and initialization from LdapUserGroupBuilder.
> Changed LdapUserGroupBuilder to extends the abstact source.
> Changed FileSourceUserGroupBuilder to extends the abstract source, and modified updateSink
to use the mappers.
> Added unit tests for FileSourceUserGroupBuilder, and one for LdapUserGroupBuilder to
ensure mapping still works.
> 
> 
> Diffs
> -----
> 
>   ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapUserGroupBuilder.java
b12d209 
>   ugsync/src/main/java/org/apache/ranger/unixusersync/process/FileSourceUserGroupBuilder.java
312f383 
>   ugsync/src/main/java/org/apache/ranger/usergroupsync/AbstractUserGroupSource.java PRE-CREATION

>   ugsync/src/test/java/org/apache/ranger/unixusersync/process/FileSourceUserGroupBuilderTest.java
PRE-CREATION 
>   ugsync/src/test/java/org/apache/ranger/usergroupsync/LdapUserGroupTest.java b285e78

>   ugsync/src/test/java/org/apache/ranger/usergroupsync/PolicyMgrUserGroupBuilderTest.java
0d817f6 
>   ugsync/src/test/resources/usergroups-dns.csv PRE-CREATION 
>   ugsync/src/test/resources/usergroups-other-delim.csv PRE-CREATION 
>   ugsync/src/test/resources/usergroups.csv PRE-CREATION 
>   ugsync/src/test/resources/usergroups.json PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47033/diff/
> 
> 
> Testing
> -------
> 
> - Unit tests
> - Tested full installation using usergroup sync with a file source and mappings
> 
> 
> Thanks,
> 
> Bryan Bende
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message