ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 47897: RANGER-996 - The PolicyRefresher doesn't cache policies if the directory doesn't already exist
Date Fri, 27 May 2016 10:36:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47897/#review135207
-----------------------------------------------------------




agents-common/src/main/java/org/apache/ranger/plugin/util/PolicyRefresher.java (line 311)
<https://reviews.apache.org/r/47897/#comment200243>

    If exceptions from mkdirs() are not caught here, it will cause PolicyRefresher() thread
to exit. Please add a catch block here to log a warning and ignore the exception.


- Madhan Neethiraj


On May 27, 2016, 10:05 a.m., Colm O hEigeartaigh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47897/
> -----------------------------------------------------------
> 
> (Updated May 27, 2016, 10:05 a.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-996
>     https://issues.apache.org/jira/browse/RANGER-996
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> The PolicyRefresher doesn't cache policies if the directory doesn't already exist
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/util/PolicyRefresher.java 91a23b3

> 
> Diff: https://reviews.apache.org/r/47897/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Colm O hEigeartaigh
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message