ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qiang Zhang <zhangqia...@zte.com.cn>
Subject Review Request 54937: At the beginning of the security-admin/scripts/setup.sh file there are three logical errors.
Date Wed, 21 Dec 2016 15:31:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54937/
-----------------------------------------------------------

Review request for ranger, Don Bosco Durai, Madhan Reddy, and Ramesh Mani.


Bugs: RANGER-1275
    https://issues.apache.org/jira/browse/RANGER-1275


Repository: ranger


Description
-------

At the beginning of the security-admin/scripts/setup.sh file there are three logical errors.
1. The judgment logic that the install.properties file exists is wrong. The reason for the
error is that the author doesn't understand the meaning of the "$?" correctly in shell script.
2. The "/var/run/ranger" path is very important. So the program should determine whether the
directory to create success.
3. The following error occurred if the 'log "$PROPFILE file not found....!!";' could be executed.
./setup.sh: line 27: log: command not found

Reproducible Steps?
-------------------------------------------------------------------------------
1. Run "mv install.properties install.properties.bak" command.
2. Run setup.sh.
Result:
The following statement was not executed.
log "$PROPFILE file not found....!!";
exit 1;
---------------------------------------------------------------------------------------
1. Comment out the line 26 and 29 lines and add "exit 0" at the 30 line in the security-admin/scripts/setup.sh
file.
2. Run setup.sh.
Result.
./setup.sh: line 27: log: command not found


Diffs
-----

  security-admin/scripts/setup.sh 2ec26f7 

Diff: https://reviews.apache.org/r/54937/diff/


Testing
-------


Thanks,

Qiang Zhang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message