ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alok Lal <al...@ebay.com>
Subject Re: Review Request 54940: RANGER-1278 - Allow LDAP authentication without configuring group information
Date Thu, 22 Dec 2016 18:28:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54940/#review159987
-----------------------------------------------------------


Ship it!





security-admin/src/main/java/org/apache/ranger/security/handler/RangerAuthenticationProvider.java
(line 222)
<https://reviews.apache.org/r/54940/#comment231011>

    Small nit: Not everywhere, but at several places ranger code uses StringUtils.isEmpty
to do such a check.


- Alok Lal


On Dec. 21, 2016, 8:12 a.m., Colm O hEigeartaigh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54940/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2016, 8:12 a.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1278
>     https://issues.apache.org/jira/browse/RANGER-1278
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> When configuring LDAP authentication, it is required to also specify the group search
base and filter, even though the results are actually discarded. It should instead be optional
to specify the group information.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/security/handler/RangerAuthenticationProvider.java
75c4eb0 
> 
> Diff: https://reviews.apache.org/r/54940/diff/
> 
> 
> Testing
> -------
> 
> Tested the admin service against LDAP.
> 
> 
> Thanks,
> 
> Colm O hEigeartaigh
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message