ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ankita Sinha <ankita.si...@freestoneinfotech.com>
Subject Re: Review Request 53967: Ranger-1210: Ranger Hive Plugin does not throw an exception when an INSERT/DELETE grant is issued from beeline
Date Tue, 27 Dec 2016 09:39:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53967/#review160143
-----------------------------------------------------------




hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java
(line 1186)
<https://reviews.apache.org/r/53967/#comment231181>

    Can "Insert" and "Delete" be added as enum in HiveAccessType and used.


- Ankita Sinha


On Nov. 23, 2016, 7:18 p.m., Yan Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53967/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2016, 7:18 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: Ranger-1210
>     https://issues.apache.org/jira/browse/Ranger-1210
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> beeline>grant insert on test10 to user userx;
> returns OK.
> 
> But actually the hive log has a warning entry:
> grant/revoke: unexpected privilege type 'DELETE'. Ignored
> The policy is actually created but with no policy items. While the "UPDATE" grant properly
sets up the policy item.
> According to https://cwiki.apache.org/confluence/display/RANGER/Hive+Commands+to+Ranger+Permission+Mapping
> Both INSERT and DELETE should be mapped to UPDATE.
> What user experiences is that the grant of INSERT/DELETE has no effect at all even the
return status is good.
> So we should throw an exception with an informational message about the INSERR/DELET=>UPDATE
mapping.
> 
> 
> Diffs
> -----
> 
>   hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java
92fc2e7 
> 
> Diff: https://reviews.apache.org/r/53967/diff/
> 
> 
> Testing
> -------
> 
> Manual tests ok.
> 
> 
> Thanks,
> 
> Yan Zhou
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message