ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Don Bosco Durai <bo...@apache.org>
Subject Re: Review Request 54978: RANGER-1279 - Make static variable RangerCSRFPreventionFilter.IS_CSRF_ENABLED private
Date Tue, 27 Dec 2016 21:08:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54978/#review160192
-----------------------------------------------------------


Ship it!




Ship It!

- Don Bosco Durai


On Dec. 22, 2016, 2:20 p.m., Colm O hEigeartaigh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54978/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2016, 2:20 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1279
>     https://issues.apache.org/jira/browse/RANGER-1279
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> The static configuration variable RangerCSRFPreventionFilter.IS_CSRF_ENABLED is public,
meaning that a malicious application running in the same JVM as Ranger could disable CSRF
protection. It should be private instead.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerCSRFPreventionFilter.java
556e2dc 
> 
> Diff: https://reviews.apache.org/r/54978/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Colm O hEigeartaigh
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message