ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qiang Zhang <zhangqia...@zte.com.cn>
Subject Review Request 55063: Comment lines have not been filtered out when the populate_global_dict function parsed install.properties in security-admin/scripts/db_setup.py.
Date Wed, 28 Dec 2016 02:57:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55063/
-----------------------------------------------------------

Review request for ranger, Don Bosco Durai, Madhan Neethiraj, Selvamohan Neethiraj, and Velmurugan
Periasamy.


Bugs: RANGER-1284
    https://issues.apache.org/jira/browse/RANGER-1284


Repository: ranger


Description
-------

Comment lines have not been filtered out when the populate_global_dict function parsed install.properties
in security-admin/scripts/db_setup.py. So if we use '#' to comment a line and it includes
'=', the comment will not work. On the right of the '=', it will be parsed as a key and the
left will be parsed as a value. Invalid parsing will degrade the performance.


Diffs
-----

  security-admin/scripts/db_setup.py 7cd1ef0 

Diff: https://reviews.apache.org/r/55063/diff/


Testing
-------


Thanks,

Qiang Zhang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message