ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alok Lal <al...@ebay.com>
Subject Re: Review Request 55008: Currently the ranger-admin will be aborted when the exception occured. We should get the default value instead of aborted.
Date Wed, 28 Dec 2016 18:30:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55008/#review160236
-----------------------------------------------------------


Ship it!




I applied the patch it applies cleanly and hand checked callers of the two functions being
changed.  

Outside of the two nits, changes are good.  In anticipation of that fix I'm giving my ship-it
to the patch.

- Alok Lal


On Dec. 22, 2016, 10:54 p.m., Qiang Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55008/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2016, 10:54 p.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Madhan Reddy, Ramesh Mani, Selvamohan Neethiraj,
and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1280
>     https://issues.apache.org/jira/browse/RANGER-1280
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> I failed to run the ranger-admin command and couldn't find any error messages in log
file after set ranger.service.http.connector.attrib.maxHeaderCount=aa(string value) in ranger-admin-site.xml
file. I analyzed the source codes and found the reason.
> I found there are two questions after check the source codes in EmbeddedServer.java.
> 1. No exception pop out when called Integer.parseInt() and Long.parseLong() function.
Once abnormal, the program aborted directly without log.
> 2. The catch captures anomaly without log in the loadConfig function. It only calls e.printStackTrace()
function.
> 
> Currently the program will be aborted when the exception occured. We should get the default
value instead of aborted.
> 
> We have tested our patch strictly.
> 
> 
> Diffs
> -----
> 
>   embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java
7ebba8a 
> 
> Diff: https://reviews.apache.org/r/55008/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message