ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qiang Zhang <zhangqia...@zte.com.cn>
Subject Re: Review Request 55063: Comment lines have not been filtered out when the populate_global_dict function parsed install.properties in security-admin/scripts/db_setup.py.
Date Thu, 29 Dec 2016 15:29:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55063/
-----------------------------------------------------------

(Updated Dec. 29, 2016, 3:29 p.m.)


Review request for ranger, Don Bosco Durai, Madhan Neethiraj, Selvamohan Neethiraj, and Velmurugan
Periasamy.


Bugs: RANGER-1284
    https://issues.apache.org/jira/browse/RANGER-1284


Repository: ranger


Description (updated)
-------

Comment lines have not been filtered out when the populate_global_dict function parsed install.properties
in security-admin/scripts/db_setup.py. So if we use '#' to comment a line and it includes
'=', the comment will not work. On the left of the '=', it will be parsed as a key and the
right will be parsed as a value. As a result, there are two problems as follows:
1. There are invalid attribute values in globalDict variable.
2. Invalid parsing will degrade the performance of program.


Diffs
-----

  security-admin/scripts/db_setup.py 7cd1ef0 

Diff: https://reviews.apache.org/r/55063/diff/


Testing
-------


Thanks,

Qiang Zhang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message