ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Qiang Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (RANGER-1275) At the beginning of the security-admin/scripts/setup.sh file there are two logical errors.
Date Wed, 21 Dec 2016 12:23:58 GMT

     [ https://issues.apache.org/jira/browse/RANGER-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Qiang Zhang updated RANGER-1275:
--------------------------------
    Description: 
1. The judgment logic that the install.properties file exists is wrong. The reason for the
error is that the author doesn't understand the meaning of the "$?" correctly in shell script.

2. The "/var/run/ranger" path is very important. So the program should determine whether the
directory to create success.

Reproducible Steps:
1. Run "mv install.properties install.properties.bak" command. 
2. Run setup.sh. 
Result:
The following statement was not executed.
log "$PROPFILE file not found....!!";
exit 1;

  was:
1. The judgment logic that the install.properties file exists is wrong. The reason for the
error is that the author doesn't understand the meaning of the "$?" correctly in shell script.

2. The "/var/run/ranger" path is very important. So the program should determine whether the
directory to create success.


> At the beginning of the security-admin/scripts/setup.sh file there are two logical errors.
> ------------------------------------------------------------------------------------------
>
>                 Key: RANGER-1275
>                 URL: https://issues.apache.org/jira/browse/RANGER-1275
>             Project: Ranger
>          Issue Type: Bug
>          Components: admin
>            Reporter: Qiang Zhang
>            Assignee: Qiang Zhang
>              Labels: patch
>
> 1. The judgment logic that the install.properties file exists is wrong. The reason for
the error is that the author doesn't understand the meaning of the "$?" correctly in shell
script. 
> 2. The "/var/run/ranger" path is very important. So the program should determine whether
the directory to create success.
> Reproducible Steps:
> 1. Run "mv install.properties install.properties.bak" command. 
> 2. Run setup.sh. 
> Result:
> The following statement was not executed.
> log "$PROPFILE file not found....!!";
> exit 1;



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message