ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qiang Zhang <zhangqia...@zte.com.cn>
Subject Review Request 55127: In the MysqlConf class of security-admin/scripts/db_setup.py, the auditdb_operation function has two problems.
Date Tue, 03 Jan 2017 07:17:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55127/
-----------------------------------------------------------

Review request for ranger, Don Bosco Durai, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj,
and Velmurugan Periasamy.


Bugs: https://issues.apache.org/jira/browse/RANGER-1286
    https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/RANGER-1286


Repository: ranger


Description
-------

In the MysqlConf class of security-admin/scripts/db_setup.py, the auditdb_operation function
has following two problems.
1. Checked audit database connection using audit_db_name?db_user?db_password value, which
were set in install.properties file. Now based on the logic, the Ranger schema database and
the Audit Store database must use same database, whether the program cannot be executed correctly.
The right logic should be using audit_db_name?audit_db_user?audit_db_password value, which
were set in install.properties file, to check audit database connection.
2. It called the grant_audit_db_user function. At the beginning of the grant_audit_db_user
the hosts_arr variable was set ["%", "localhost"] as default value. The hosts_arr variable
will include two localhost values if self.host equal to localhost. As a result, the back code
segment will be executed repeatedly, And the performance of the program will be reduced.


Diffs
-----

  security-admin/scripts/db_setup.py 430aa47 

Diff: https://reviews.apache.org/r/55127/diff/


Testing
-------


Thanks,

Qiang Zhang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message