ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qiang Zhang <zhangqia...@zte.com.cn>
Subject Re: Review Request 54886: RANGER-ATLAS testConnection feature
Date Tue, 03 Jan 2017 07:48:15 GMT


> On 十二月 27, 2016, 9:34 a.m., Ankita Sinha wrote:
> > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/RangerServiceAtlas.java,
line 19
> > <https://reviews.apache.org/r/54886/diff/4/?file=1591717#file1591717line19>
> >
> >     Tested the patch and Test Connection is failing. Do the review request is missing
some changes in "admin-web.xml"
> 
> Qiang Zhang wrote:
>     Hi Ankita  I upload the operator steps STEPS-TestConnection-for-Ranger-Atlas-plugin.docx
.especially the params for the connection  i don't edit the admin-web.xml .thanks for review!
> 
> Ankita Sinha wrote:
>     Thanks for the steps, the configuration parameter which I am using is similar to
as you have mentioned in the doc and still the test connection is failing. For it to be successful
I manually copied "ranger-atlas-plugin-<version>.jar" in atlas folder inside "ews/webapp/WEB-INF/classes/ranger-plugins/"
in ranger-admin. To get this jar automatically inside "ranger-plugins/atlas" folder "admin-web.xml"
need to have entry for atlas.

Ok. Thanks! You are right.I updated the code according to your opinion , Edit admin-web.xml
add atlas moduleSet,It can automatically copy ranger-atlas-plugin-0.7.0-SNAPSHOT.jar to "ranger-plugins/atlas"
folder.


- Qiang


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54886/#review160142
-----------------------------------------------------------


On 一月 3, 2017, 7:42 a.m., Qiang Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54886/
> -----------------------------------------------------------
> 
> (Updated 一月 3, 2017, 7:42 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay Kulkarni,
Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/RANGER-1271
>     https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/RANGER-1271
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> RANGER-ATLAS testConnection feature
> 
> 
> Diffs
> -----
> 
>   plugin-atlas/src/main/java/org/apache/ranger/services/atlas/RangerServiceAtlas.java
cb5a7eb 
>   plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasClient.java
PRE-CREATION 
>   plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasConnectionMgr.java
PRE-CREATION 
>   plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasResourceMgr.java
PRE-CREATION 
>   src/main/assembly/admin-web.xml b06cdec 
> 
> Diff: https://reviews.apache.org/r/54886/diff/
> 
> 
> Testing
> -------
> 
> This feature is for connect Ranger and Atlas. We through the following steps to ensure
the quality of the patch:
> 1. Cloned latest ranger code.
> 2. Checked our new code and build new version using jenkins.
> 3. Build functional verification environment in Centos 6.5.
> 4. Tested our patch strictly. And using web client to verify new feature successfully.

> 5. Edit src/main/assembly/admin-web.xml add atlas moduleSet
> 6. Build and update patch for RANGER-1271.
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message