ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Colm O hEigeartaigh <cohei...@apache.org>
Subject Re: Review Request 54905: Add tests for Kafka + SASL_SSL + PLAIN
Date Mon, 16 Jan 2017 15:12:19 GMT


> On Dec. 22, 2016, 5:31 p.m., Velmurugan Periasamy wrote:
> > plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerAuthorizerTest.java,
line 21
> > <https://reviews.apache.org/r/54905/diff/1/?file=1589799#file1589799line21>
> >
> >     Colm - I am not able to apply this patch. Can you please check?
> >     
> >     ```
> >     $ git pull
> >     Already up-to-date.
> >     $ git status
> >     On branch master
> >     Your branch is up-to-date with 'origin/master'.
> >     nothing to commit, working directory clean
> >     $ git apply --check -v < ~/Downloads/patches/ranger/0001-RANGER-1273-Add-tests-for-Kafka-SASL_SSL-PLAIN.patch.old
> >     Checking patch plugin-kafka/pom.xml...
> >     Checking patch plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerAuthorizerSASLSSLTest.java...
> >     Checking patch plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerAuthorizerTest.java...
> >     error: while searching for:
> >     import java.io.FileOutputStream;
> >     import java.math.BigInteger;
> >     import java.net.ServerSocket;
> >     import java.security.KeyPair;
> >     import java.security.KeyPairGenerator;
> >     import java.security.KeyStore;
> >     import java.security.SecureRandom;
> >     import java.security.cert.Certificate;
> >     import java.security.cert.X509Certificate;
> >     import java.util.Arrays;
> >     import java.util.Date;
> >     import java.util.Properties;
> >     import java.util.concurrent.Future;
> >     
> >     
> >     error: patch failed: plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerAuthorizerTest.java:21
> >     error: plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerAuthorizerTest.java:
patch does not apply
> >     Checking patch plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaTestUtils.java...
> >     Checking patch plugin-kafka/src/test/resources/kafka_plain.jaas...
> >     Checking patch pom.xml...
> >     ```

I uploaded a fixed patch...thanks.


- Colm


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54905/#review159979
-----------------------------------------------------------


On Jan. 16, 2017, 3:11 p.m., Colm O hEigeartaigh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54905/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2017, 3:11 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1273
>     https://issues.apache.org/jira/browse/RANGER-1273
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Currently we have tests in Ranger for authorization for Kafka using SSL. We should also
add tests for authorization for SASL_SSL + PLAIN.
> 
> 
> Diffs
> -----
> 
>   plugin-kafka/pom.xml 05aace2 
>   plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerAuthorizerSASLSSLTest.java
PRE-CREATION 
>   plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerAuthorizerTest.java
4a4e2b5 
>   plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaTestUtils.java
PRE-CREATION 
>   plugin-kafka/src/test/resources/kafka_plain.jaas PRE-CREATION 
>   pom.xml 13e5da8 
> 
> Diff: https://reviews.apache.org/r/54905/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Colm O hEigeartaigh
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message