ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Colm O hEigeartaigh <cohei...@apache.org>
Subject Review Request 55581: RANGER-1309 - Check for header first in RangerCSRFPreventionFilter
Date Mon, 16 Jan 2017 15:51:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55581/
-----------------------------------------------------------

Review request for ranger.


Bugs: RANGER-1309
    https://issues.apache.org/jira/browse/RANGER-1309


Repository: ranger


Description
-------

In the RangerCSRFPreventionFilter, we should check to see if the required header is present
first, for efficiency reasons. Right now we check the user agent first, which involves a call
to matcher.matches() on each of the (default) browser user agent Strings.


Diffs
-----

  security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerCSRFPreventionFilter.java
4942eb3 

Diff: https://reviews.apache.org/r/55581/diff/


Testing
-------


Thanks,

Colm O hEigeartaigh


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message