ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Colm O hEigeartaigh <cohei...@apache.org>
Subject Re: Review Request 55128: RANGER-1287:Remove code duplication from EmbeddedServer start method
Date Mon, 16 Jan 2017 16:59:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55128/#review161756
-----------------------------------------------------------


Ship it!




Ship It!

- Colm O hEigeartaigh


On Jan. 6, 2017, 12:43 a.m., Qiang Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55128/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2017, 12:43 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Madhan Neethiraj,
Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1287
>     https://issues.apache.org/jira/browse/RANGER-1287
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> #Solution:
> 1.The following code is repeated twice, remove one of them.
> ```java
> valve.setRotatable(true);
> ```
> 
> 2.The following code is repeated three times, removed by refactored to a method startServer(final
Tomcat server).
> ```java
> try{
> 	server.start();
> 	server.getServer().await();
> 	shutdownServer();
> }catch (LifecycleException e) {
> 	LOG.severe("Tomcat Server failed to start:" + e.toString());
> 	e.printStackTrace();
> }catch (Exception e) {
> 	LOG.severe("Tomcat Server failed to start:" + e.toString());
> 	e.printStackTrace();
> }
> ```
> 
> 
> Diffs
> -----
> 
>   embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java
7ebba8a 
> 
> Diff: https://reviews.apache.org/r/55128/diff/
> 
> 
> Testing
> -------
> 
> #Test Result:
> 1.Start Ranger-Admin success, and Ranger-Admin is not in security mode;
> 2.Start Ranger-Admin success, and Ranger-Admin is in security mode with Kerberos Authentication;
> 3.Find access_log.2017-01-03.15.log generated in dircetory ranger-<version>-admin/ews/logs.
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message