ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Velmurugan Periasamy <vperias...@hortonworks.com>
Subject Re: Review Request 55581: RANGER-1309 - Check for header first in RangerCSRFPreventionFilter
Date Tue, 17 Jan 2017 18:13:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55581/#review161896
-----------------------------------------------------------


Ship it!




Ship It!

- Velmurugan Periasamy


On Jan. 16, 2017, 3:51 p.m., Colm O hEigeartaigh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55581/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2017, 3:51 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1309
>     https://issues.apache.org/jira/browse/RANGER-1309
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> In the RangerCSRFPreventionFilter, we should check to see if the required header is present
first, for efficiency reasons. Right now we check the user agent first, which involves a call
to matcher.matches() on each of the (default) browser user agent Strings.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerCSRFPreventionFilter.java
4942eb3 
> 
> Diff: https://reviews.apache.org/r/55581/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Colm O hEigeartaigh
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message