ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Colm O hEigeartaigh <cohei...@apache.org>
Subject Re: Review Request 55616: The SYNC_SOURCE atribute only supports unix and ldap for ranger usersync at present, it's default value should be unix. Current the installation process directly exited because of using default configuration.
Date Thu, 19 Jan 2017 09:47:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55616/#review162261
-----------------------------------------------------------


Ship it!




Ship It!

- Colm O hEigeartaigh


On Jan. 19, 2017, 8 a.m., Qiang Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55616/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2017, 8 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Colm O hEigeartaigh, Ramesh Mani, Selvamohan
Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1312
>     https://issues.apache.org/jira/browse/RANGER-1312
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> The SYNC_SOURCE atribute only supports unix and ldap for ranger usersync at present,
it's default value is unix. But It was assigned an empty value as default configuration value
in configuration file. Current the program would directly exit when user used default configuration
to install ranger usersync. The logic code is as following:
> if (syncSource == SYNC_SOURCE_UNIX):
>     ret['ranger.usersync.source.impl.class'] = 'org.apache.ranger.unixusersync.process.UnixUserGroupBuilder'
>     if (SYNC_INTERVAL_NEW_KEY not in ret or len(str(ret[SYNC_INTERVAL_NEW_KEY])) == 0):
>         ret[SYNC_INTERVAL_NEW_KEY] = "300000"
>     else:
>         ret[SYNC_INTERVAL_NEW_KEY] = int(ret[SYNC_INTERVAL_NEW_KEY]) * 60000
> elif (syncSource == SYNC_SOURCE_LDAP):
>     ldapPass=ret[SYNC_LDAP_BIND_PASSWORD_KEY]
>     ret['ranger.usersync.source.impl.class'] = 'org.apache.ranger.ldapusersync.process.LdapUserGroupBuilder'
>     if (SYNC_INTERVAL_NEW_KEY not in ret or len(str(ret[SYNC_INTERVAL_NEW_KEY])) == 0):
>         ret[SYNC_INTERVAL_NEW_KEY] = "3600000"
>     else:
>         ret[SYNC_INTERVAL_NEW_KEY] = int(ret[SYNC_INTERVAL_NEW_KEY]) * 60000
> else:
>     print "ERROR: Invalid value (%s) defined for %s in install.properties. Only valid
values are %s" % (syncSource, SYNC_SOURCE_KEY,SYNC_SOURCE_LIST)
>     sys.exit(1)
> 
> 
> Diffs
> -----
> 
>   unixauthservice/scripts/install.properties e784dda 
> 
> Diff: https://reviews.apache.org/r/55616/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message