ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qiang Zhang <zhangqia...@zte.com.cn>
Subject Re: Review Request 55702: There are two defects in install scripts for ranger usersync process
Date Thu, 19 Jan 2017 14:13:59 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated 一月 19, 2017, 2:13 p.m.)

Review request for ranger, Don Bosco Durai, Colm O hEigeartaigh, Ramesh Mani, Selvamohan Neethiraj,
and Velmurugan Periasamy.

Bugs: RANGER-1317

Repository: ranger


There are two defects in install scripts for ranger usersync process:
1. The rangerBaseDirName variable equals to /etc/ranger when we install the ranger usersync
process. So the usersync can only be installed in /etc/ranger. As a result, the installer
can't plan the installation path according to their needs.In some system environment, it is
not reasonable. 
There is a configuration attribute to resolve the issue in ranger-admin. Similarly, the install
scripts for ranger usersync process should also provide configuration attributes to solve
this issue.
2. The usersyncBaseDirName variable equals to usersync. The install program uses following
code to create directorys.
dirList = [ rangerBaseDirName, usersyncBaseDirName, confFolderName, certFolderName ]
In above list other variables are absolute value of the path, but usersyncBaseDirName is not.
Above list should be modified as following:
dirList = [ rangerBaseDirName, usersyncBaseDirFullName, confFolderName, certFolderName ]
The following code should be modified also.
fixPermList = [ ".", usersyncBaseDirName, confFolderName, certFolderName ]

Diffs (updated)

  unixauthservice/scripts/install.properties e784dda 
  unixauthservice/scripts/setup.py 673a48f 

Diff: https://reviews.apache.org/r/55702/diff/



Qiang Zhang

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message