ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qiang Zhang <zhangqia...@zte.com.cn>
Subject Re: Review Request 55702: There are two defects in install scripts for ranger usersync process
Date Thu, 19 Jan 2017 14:15:40 GMT


> On 一月 19, 2017, 10:04 a.m., Colm O hEigeartaigh wrote:
> > > +# The base path for the usersync process
> > > +ranger_base_dir = /opt/ranger
> > 
> > Shouldn't this be /etc/ranger?

Ok. You are right. That is my test data. I had modified it according to your review. And I
rebuilt patch also. Thanks.


- Qiang


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55702/#review162265
-----------------------------------------------------------


On 一月 19, 2017, 2:13 p.m., Qiang Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55702/
> -----------------------------------------------------------
> 
> (Updated 一月 19, 2017, 2:13 p.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Colm O hEigeartaigh, Ramesh Mani, Selvamohan
Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1317
>     https://issues.apache.org/jira/browse/RANGER-1317
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> There are two defects in install scripts for ranger usersync process:
> 1. The rangerBaseDirName variable equals to /etc/ranger when we install the ranger usersync
process. So the usersync can only be installed in /etc/ranger. As a result, the installer
can't plan the installation path according to their needs.In some system environment, it is
not reasonable. 
> There is a configuration attribute to resolve the issue in ranger-admin. Similarly, the
install scripts for ranger usersync process should also provide configuration attributes to
solve this issue.
> 2. The usersyncBaseDirName variable equals to usersync. The install program uses following
code to create directorys.
> dirList = [ rangerBaseDirName, usersyncBaseDirName, confFolderName, certFolderName ]
> In above list other variables are absolute value of the path, but usersyncBaseDirName
is not. Above list should be modified as following:
> dirList = [ rangerBaseDirName, usersyncBaseDirFullName, confFolderName, certFolderName
]
> The following code should be modified also.
> fixPermList = [ ".", usersyncBaseDirName, confFolderName, certFolderName ]
> 
> 
> Diffs
> -----
> 
>   unixauthservice/scripts/install.properties e784dda 
>   unixauthservice/scripts/setup.py 673a48f 
> 
> Diff: https://reviews.apache.org/r/55702/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message