ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Velmurugan Periasamy <vperias...@hortonworks.com>
Subject Re: Review Request 55708: RANGER-1315 : [export/import] if input file content is not valid for import then it does not give proper error, it gives null pointer exception in logs
Date Mon, 23 Jan 2017 16:05:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55708/#review162644
-----------------------------------------------------------


Ship it!




Ship It!

- Velmurugan Periasamy


On Jan. 19, 2017, 8:21 a.m., Mehul Parikh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55708/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2017, 8:21 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Pradeep Agrawal,
and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1315
>     https://issues.apache.org/jira/browse/RANGER-1315
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Improvise error reporting for import / export API
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java df03876 
>   security-admin/src/main/java/org/apache/ranger/common/RangerServicePoliciesCache.java
2788fd1 
>   security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 0a367e6 
>   security-admin/src/main/webapp/scripts/views/DownloadServicePolicy.js 4532612 
>   security-admin/src/main/webapp/scripts/views/UploadServicePolicy.js dcf038e 
>   security-admin/src/main/webapp/scripts/views/policymanager/ServiceLayout.js f914ed2

>   security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 5d93eeb 
>   security-admin/src/main/webapp/styles/xa.css e2abab9 
>   security-admin/src/main/webapp/templates/common/uploadservicepolicy_tmpl.html f78446f

> 
> Diff: https://reviews.apache.org/r/55708/diff/
> 
> 
> Testing
> -------
> 
> Verified : 
> 
> * Error reporting for below given cases :: 
> * If service name and policy name are not provided, showing relative error message that
: policy name or service name are missing in the imported data file.
> * If any of the required fields from policy are missing then also failing the import
task with error shown for missing fields.
> 
> 
> Thanks,
> 
> Mehul Parikh
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message