ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Abhay Kulkarni <akulka...@hortonworks.com>
Subject Review Request 55915: Update Ranger plugin handling of service-not-found error
Date Wed, 25 Jan 2017 08:32:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55915/
-----------------------------------------------------------

Review request for ranger and Madhan Neethiraj.


Bugs: RANGER-1329
    https://issues.apache.org/jira/browse/RANGER-1329


Repository: ranger


Description
-------

If the service is deleted or renamed in Ranger Admin, the plugins should run with no policy
to determine authorization of resource-accesses.


Diffs
-----

  agents-common/src/main/java/org/apache/ranger/admin/client/RangerAdminClient.java 6755e15

  agents-common/src/main/java/org/apache/ranger/admin/client/RangerAdminRESTClient.java 646004a

  agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerAdminTagRetriever.java
9c336bf 
  agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerFileBasedTagRetriever.java
248aafa 
  agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java
43d501a 
  agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagRetriever.java
a5eeeaa 
  agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java c34aa19

  agents-common/src/main/java/org/apache/ranger/plugin/util/PolicyRefresher.java 91c24c6 
  agents-common/src/main/java/org/apache/ranger/plugin/util/RangerServiceNotFoundException.java
PRE-CREATION 
  knox-agent/src/main/java/org/apache/ranger/admin/client/RangerAdminJersey2RESTClient.java
1c649de 
  ranger-plugin-classloader/src/main/java/org/apache/ranger/plugin/classloader/RangerPluginClassLoaderUtil.java
156fec9 
  security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 7e50fd5 
  security-admin/src/main/java/org/apache/ranger/biz/TagDBStore.java 5fbc259 
  security-admin/src/main/java/org/apache/ranger/common/RESTErrorUtil.java c98487f 
  security-admin/src/main/java/org/apache/ranger/common/ServiceUtil.java 84675fc 
  security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java b6018fb 
  security-admin/src/main/java/org/apache/ranger/rest/TagREST.java feb6a54 
  security-admin/src/main/resources/META-INF/jpa_named_queries.xml c8c3d2f 
  security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java fafd4e0 
  security-admin/src/test/java/org/apache/ranger/rest/TestTagREST.java 9608544 

Diff: https://reviews.apache.org/r/55915/diff/


Testing
-------

Tested with localVM.
1. Deleted/renamed service in Ranger Admin, and ensured that the policycache is moved to a
different name, and plugin is reinitialized with no policies. This behavior is controlled
by a configuration variable 'ranger.disable.policycache.when.service.not.found'.
2. Disabled service in Ranger Admin, and ensured that the policycache is not modified/moved,
and policy-engine continues to use existing policies.


Thanks,

Abhay Kulkarni


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message