ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zsombor Gegesy <gzsom...@gmail.com>
Subject Re: Review Request 56035: RANGER-1334: Good coding practices in Ranger Usersync
Date Fri, 27 Jan 2017 20:06:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56035/#review163322
-----------------------------------------------------------




ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapDeltaUserGroupBuilder.java
(line 699)
<https://reviews.apache.org/r/56035/#comment234740>

    You should use the LOG, it's not a good practice to call directly the printStackTrace()
which ends up in the consol


- Zsombor Gegesy


On Jan. 27, 2017, 7:35 p.m., Sailaja Polavarapu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56035/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2017, 7:35 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj,
Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1334
>     https://issues.apache.org/jira/browse/RANGER-1334
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Fixed few issues found in the recent changes in the usersync code.
> 
> 
> Diffs
> -----
> 
>   ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapDeltaUserGroupBuilder.java
0779918 
>   ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapPolicyMgrUserGroupBuilder.java
0b909d1 
>   ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java
25c0824 
> 
> Diff: https://reviews.apache.org/r/56035/diff/
> 
> 
> Testing
> -------
> 
> Confirmed all the unit tests ran successfully.
> 
> 
> Thanks,
> 
> Sailaja Polavarapu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message