ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 59807: Good coding practice suggested by static code analysis
Date Mon, 05 Jun 2017 20:36:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59807/#review176948
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On June 5, 2017, 5:17 p.m., Abhay Kulkarni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59807/
> -----------------------------------------------------------
> 
> (Updated June 5, 2017, 5:17 p.m.)
> 
> 
> Review request for ranger and Madhan Neethiraj.
> 
> 
> Bugs: RANGER-1628
>     https://issues.apache.org/jira/browse/RANGER-1628
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Fixed code to implement good coding practices suggested by static code analysis.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyengine/PolicyEvaluatorForTag.java
b5f5146 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerPolicyEvaluator.java
3d000cc 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerPolicyItemEvaluator.java
492b3a2 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyresourcematcher/RangerPolicyResourceEvaluator.java
900b2e7 
>   agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/ResourceMatcher.java
aad353d 
> 
> 
> Diff: https://reviews.apache.org/r/59807/diff/1/
> 
> 
> Testing
> -------
> 
> Compiled clean and passed all unit tests.
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message