ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Colm O hEigeartaigh <cohei...@apache.org>
Subject Re: Review Request 59801: Additional debug logging for user sync
Date Tue, 06 Jun 2017 09:09:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59801/#review177008
-----------------------------------------------------------



Looks fine, but could you resubmit using git format-patch (see: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=55151244).
Also there are two extra whitespace changes in the patch that could be removed.

- Colm O hEigeartaigh


On June 5, 2017, 10:04 a.m., Rob Vesse wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59801/
> -----------------------------------------------------------
> 
> (Updated June 5, 2017, 10:04 a.m.)
> 
> 
> Review request for ranger.
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Adds some extra debug logging to user sync that logs the actual group query being used
which is useful when trying to debug a user sync configuration that is not working as expected
> 
> 
> Diffs
> -----
> 
>   ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapUserGroupBuilder.java
8cf6816a0 
> 
> 
> Diff: https://reviews.apache.org/r/59801/diff/1/
> 
> 
> Testing
> -------
> 
> Testing local build in my environment and verified that the extra logging was seen when
log4j was turned up to `DEBUG`
> 
> 
> Thanks,
> 
> Rob Vesse
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message