ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Colm O hEigeartaigh <cohei...@apache.org>
Subject Re: Review Request 60034: Support KNOX SSO Token based authentication on Ranger REST API calls
Date Tue, 13 Jun 2017 08:49:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60034/#review177715
-----------------------------------------------------------



Please put curly brackets around the two one-line if statements: if(LOG.isDebugEnabled())

- Colm O hEigeartaigh


On June 13, 2017, 8:23 a.m., Ankita Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60034/
> -----------------------------------------------------------
> 
> (Updated June 13, 2017, 8:23 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj,
Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1582
>     https://issues.apache.org/jira/browse/RANGER-1582
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Actual :
> Currently Knox SSO is just supported from Ranger UI through web browser.
> 
> Expected :
> Support KNOX SSO Token based authentication on Ranger REST API calls.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSSOAuthenticationFilter.java
ffb60b9 
>   security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 4f5f1d3 
> 
> 
> Diff: https://reviews.apache.org/r/60034/diff/1/
> 
> 
> Testing
> -------
> 
> 1. Checked Knox SSO for REST API Calls
> 2. Knox SSO working as expected from Ranger UI
> 3. Tested in secure as well as simple environment.
> 
> 
> Thanks,
> 
> Ankita Sinha
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message