ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Colm O hEigeartaigh <cohei...@apache.org>
Subject Re: Review Request 60032: Remove the pmd check error
Date Tue, 13 Jun 2017 09:20:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60032/#review177717
-----------------------------------------------------------


Ship it!




Ship It!

- Colm O hEigeartaigh


On June 13, 2017, 4:36 a.m., pengjianhua wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60032/
> -----------------------------------------------------------
> 
> (Updated June 13, 2017, 4:36 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh,
Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and
Qiang Zhang.
> 
> 
> Bugs: RANGER-1636
>     https://issues.apache.org/jira/browse/RANGER-1636
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> The following information will occur when using PMD tool to check code.
> <?xml version="1.0" encoding="UTF-8"?>
> <pmd version="5.3.2" timestamp="2017-06-07T16:00:04.381">
> <file name="/submitranger/RangerCompile01/Ranger/agents-common/src/test/java/org/apache/ranger/plugin/errors/TestValidationErrorCode.java">
> <violation beginline="23" endline="23" begincolumn="1" endcolumn="74" rule="UnusedImports"
ruleset="Import Statements" package="org.apache.ranger.plugin.errors" externalInfoUrl="http://pmd.sourceforge.net/pmd-5.3.2/pmd-java/rules/java/imports.html#UnusedImports"
priority="4">
> Avoid unused imports such as 'org.apache.ranger.plugin.model.validation.ValidationFailureDetails'
> </violation>
> </file>
> <file name="/submitranger/RangerCompile01/Ranger/agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestRangerValidator.java">
> <violation beginline="62" endline="62" begincolumn="33" endcolumn="37" rule="UnusedLocalVariable"
ruleset="Unused Code" package="org.apache.ranger.plugin.model.validation" class="TestRangerValidator$RangerValidatorForTest"
method="isValid" variable="valid" externalInfoUrl="http://pmd.sourceforge.net/pmd-5.3.2/pmd-java/rules/java/unusedcode.html#UnusedLocalVariable"
priority="3">
> Avoid unused local variables such as 'valid'.
> </violation>
> </file>
> </pmd>
> <?xml version="1.0" encoding="UTF-8"?>
> <pmd version="5.3.2" timestamp="2017-06-07T15:31:08.801">
> <file name="/home/pengjianhua/gerrit/submitranger/RangerCompile/kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java">
> <violation beginline="337" endline="337" begincolumn="124" endcolumn="124" rule="UnusedFormalParameter"
ruleset="Unused Code" package="org.apache.hadoop.crypto.key" class="RangerKeyStore" method="mapToEntityBean"
variable="i" externalInfoUrl="http://pmd.sourceforge.net/pmd-5.3.2/pmd-java/rules/java/unusedcode.html#UnusedFormalParameter"
priority="3">
> Avoid unused method parameters such as 'i'.
> </violation>
> </file>
> </pmd>
> 
> 
> Diffs
> -----
> 
>   agents-common/src/test/java/org/apache/ranger/plugin/errors/TestValidationErrorCode.java
1b00c64 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java c4f7267 
> 
> 
> Diff: https://reviews.apache.org/r/60032/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pengjianhua
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message