ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ankita Sinha <ankita.si...@freestoneinfotech.com>
Subject Re: Review Request 60043: Ranger KMS should validate key name before importing into DB
Date Thu, 22 Jun 2017 13:50:36 GMT


> On June 13, 2017, 12:20 p.m., Colm O hEigeartaigh wrote:
> > Ship It!
> 
> Colm O hEigeartaigh wrote:
>     Actually, is it feasible to add some unit tests for this?

Thanks Colm, added unit tests.


- Ankita


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60043/#review177731
-----------------------------------------------------------


On June 22, 2017, 1:50 p.m., Ankita Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60043/
> -----------------------------------------------------------
> 
> (Updated June 22, 2017, 1:50 p.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj,
Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1639
>     https://issues.apache.org/jira/browse/RANGER-1639
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Actual :
> Ranger KMS does not validate key name before importing into DB. So the imported key can
have special characters in Key name.
> 
> Expected :
> Ranger KMS should validate key name before importing into DB.
> 
> 
> Diffs
> -----
> 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java 09b46bc 
>   kms/src/test/java/org/apache/hadoop/crypto/key/kms/TestRangerKeyStore.java PRE-CREATION

> 
> 
> Diff: https://reviews.apache.org/r/60043/diff/3/
> 
> 
> Testing
> -------
> 
> Below steps were followed to test this scenario
> 
> 1. Installed Hadoop KMS
> 2. Created encryption keys with combination of special characters, alphabets and numbers
> 3. Installed Ranger KMS
> 4. imported hadoop key jceks to Ranger KMS (Validation was successful)
> 
> 
> Thanks,
> 
> Ankita Sinha
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message