ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ankita Sinha <ankita.si...@freestoneinfotech.com>
Subject Review Request 61025: Good coding practice in Ranger recommended by static code analysis
Date Fri, 21 Jul 2017 12:33:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61025/
-----------------------------------------------------------

Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj,
Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-1705
    https://issues.apache.org/jira/browse/RANGER-1705


Repository: ranger


Description
-------

Good coding practice in Ranger recommended by static code analysis on
1. TestRangerKeyStore.java
2. TestServiceREST.java
3. RangerSSOAuthenticationFilter.java


Diffs
-----

  kms/src/test/java/org/apache/hadoop/crypto/key/kms/TestRangerKeyStore.java c1925f8 
  security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSSOAuthenticationFilter.java
b912e7e 
  security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java 4bb0746 


Diff: https://reviews.apache.org/r/61025/diff/1/


Testing
-------

1. Tested SSO Authentication 
2. Junit test was successful


Thanks,

Ankita Sinha


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message