ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Colm O hEigeartaigh <cohei...@apache.org>
Subject Re: Review Request 61202: Fixed-RANGER-1669:We need to support the original functionality of hive.show grant user usernam
Date Mon, 31 Jul 2017 14:12:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61202/#review181803
-----------------------------------------------------------



I'm wondering what the expected output of "show grant user X" is? I would have expected to
see the privileges that correspond to policies created in the Ranger admin service, but this
is not the case. If the output is nothing to do with Ranger policies, then I'm wondering what
the use-case is here for supporting this functionality with the Ranger authorizer?

- Colm O hEigeartaigh


On July 31, 2017, 2:15 a.m., pengjianhua wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61202/
> -----------------------------------------------------------
> 
> (Updated July 31, 2017, 2:15 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Colm O hEigeartaigh, and Qiang Zhang.
> 
> 
> Bugs: RANGER-1669
>     https://issues.apache.org/jira/browse/RANGER-1669
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> New Defects reported by Coverity Scan for Apache Ranger
> Please find the latest report on new defect(s) introduced to Apache Ranger found with
Coverity Scan.
> Null pointer dereferences  (NULL_RETURNS)
>   >>>     CID 166074:  Null pointer dereferences  (NULL_RETURNS)
>   >>>     Calling a method on null object "msObjPrivs".
>     1474                 for (HiveObjectPrivilege msObjPriv : msObjPrivs) {
>     1475                     HivePrincipal resPrincipal = new HivePrincipal(
>     1476                             msObjPriv.getPrincipalName(),
>     1477                             AuthorizationUtils.getHivePrincipalType(msObjPriv
>     1478                                     .getPrincipalType()));
>  
> Reason:   Hi, Hive also has this problem, 
>         Update patch solved this prolem for hive-plugin(Ranger-1669). hdfs-plugin has
solved by Abhay (Ranger-1695)please review again.thanks.
> 
> 
> Diffs
> -----
> 
>   hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java
6872e50 
>   hive-agent/src/test/java/org/apache/ranger/services/hive/HIVERangerAuthorizerTest.java
011d2c3 
> 
> 
> Diff: https://reviews.apache.org/r/61202/diff/2/
> 
> 
> Testing
> -------
> 
> tested it
> 
> 
> Thanks,
> 
> pengjianhua
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message