ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Abhay Kulkarni <akulka...@hortonworks.com>
Subject Re: Review Request 62313: RANGER-1647: Allow Ranger policy conditions to use tag attributes and values in Ranger -- ranger0.7 branch
Date Thu, 14 Sep 2017 22:02:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62313/#review185455
-----------------------------------------------------------




security-admin/src/main/java/org/apache/ranger/patch/PatchForTagServiceDefUpdate_J10008.java
Lines 165 (patched)
<https://reviews.apache.org/r/62313/#comment261750>

    Please review this logic. It appears that preUpdateValue will always be null. Should the
line 164 be as follows?
    
    if(serviceDefOptionsPreUpdate == null || serviceDefOptionsPreUpdate.containsKey(RangerServiceDef.OPTION_ENABLE_DENY_AND_EXCEPTIONS_IN_POLICIES))
{
    
    I think the idea is that the value of RangerServiceDef.OPTION_ENABLE_DENY_AND_EXCEPTIONS_IN_POLICIES
before the updateServiceDef needs to be restored in the database if the updateServiceDef()
call (line 154) causes the value of the option to be overwritten.


- Abhay Kulkarni


On Sept. 13, 2017, 11:33 p.m., Sailaja Polavarapu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62313/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2017, 11:33 p.m.)
> 
> 
> Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1647
>     https://issues.apache.org/jira/browse/RANGER-1647
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Merged https://reviews.apache.org/r/60140/ to ranger-0.7 branch and added patch file
to handle upgrades.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/patch/PatchForTagServiceDefUpdate_J10008.java
PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62313/diff/2/
> 
> 
> Testing
> -------
> 
> 1. Performed basic functionality tests
> 2. Ran all the unit tests with successfully.
> 
> 
> Thanks,
> 
> Sailaja Polavarapu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message