ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Colm O hEigeartaigh <cohei...@apache.org>
Subject Re: Review Request 62498: Here is a error in getTableList() when get table-list info for HiveClient class.
Date Fri, 22 Sep 2017 11:54:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62498/#review185974
-----------------------------------------------------------


Ship it!




Ship It!

- Colm O hEigeartaigh


On Sept. 22, 2017, 9:57 a.m., Qiang Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62498/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2017, 9:57 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh,
Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and
Qiang Zhang.
> 
> 
> Bugs: RANGER-1798
>     https://issues.apache.org/jira/browse/RANGER-1798
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Here is a error in getTableList() when get table-list info for HiveClient class.
> {code}
> public List<String> getTableList(String tableNameMatching, List<String> databaseList,
List<String> tblNameList) throws HadoopException  {
> 		final String 	   tblNameMatching = tableNameMatching;
> 		final List<String> dbList  	 	   = databaseList;
> 		final List<String> tblList   	   = tblNameList;
> 
> 		List<String> tableList = Subject.doAs(getLoginSubject(), new PrivilegedAction<List<String>>()
{
> 			public List<String>  run() {
> 				List<String> ret = null;
> 				try {
> 					... ...
> 				} catch (HadoopException he) {
> 					LOG.error("<== HiveClient getTblList() :Unable to get the Table List", he);
> 					throw he;
> 				}
> 				return ret;
> 			}
> 		});
> 
> 		return tableList;
> 	}
> {code}
> 
> 
> Diffs
> -----
> 
>   hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveClient.java 57305936

> 
> 
> Diff: https://reviews.apache.org/r/62498/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message