ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nitin Galave <nitin.gal...@gmail.com>
Subject Review Request 62532: RANGER-1805: Code improvement to follow best practices in js
Date Mon, 25 Sep 2017 06:08:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62532/
-----------------------------------------------------------

Review request for ranger, Gautam Borad, Mehul Parikh, and Velmurugan Periasamy.


Bugs: RANGER-1805
    https://issues.apache.org/jira/browse/RANGER-1805


Repository: ranger


Description
-------

Javascript coding best practices.


Diffs
-----

  security-admin/src/main/webapp/scripts/modules/XAOverrides.js 5810d5d 
  security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 73b4cd3 
  security-admin/src/main/webapp/scripts/utils/XAEnums.js 164e939 
  security-admin/src/main/webapp/scripts/utils/XATemplateHelpers.js 785e2c2 
  security-admin/src/main/webapp/scripts/views/DownloadServicePolicy.js 1b1a4aa 
  security-admin/src/main/webapp/scripts/views/common/AddGroup.js 81fd901 
  security-admin/src/main/webapp/scripts/views/policies/PermissionList.js 92b8334 
  security-admin/src/main/webapp/scripts/views/policymanager/ServiceLayout.js ab42b5c 
  security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 76a8aa5 
  security-admin/src/main/webapp/scripts/views/reports/UserAccessLayout.js c5dc053 
  security-admin/src/main/webapp/scripts/views/user/UserProfileForm.js a385592 
  security-admin/src/main/webapp/templates/common/Footer_tmpl.html e3accb6 
  security-admin/src/main/webapp/templates/common/downloadservicepolicy_tmpl.html 49be577

  security-admin/src/main/webapp/templates/helpers/XAHelpers.js 1766880 
  security-admin/src/main/webapp/templates/kms/KmsKeyCreate_tmpl.html 2aaac43 
  security-admin/src/main/webapp/templates/policies/RangerPolicyCreate_tmpl.html e5e4ce7 
  security-admin/src/main/webapp/templates/service/ServiceCreate_tmpl.html d79028e 
  security-admin/src/main/webapp/templates/users/GroupCreate_tmpl.html c387e68 
  security-admin/src/main/webapp/templates/users/UserCreate_tmpl.html 204e832 


Diff: https://reviews.apache.org/r/62532/diff/1/


Testing
-------

Done overall basic UI testing which includes service, policy, user, group and permission modules.


Thanks,

Nitin Galave


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message