ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Colm O hEigeartaigh <cohei...@apache.org>
Subject Re: Review Request 62539: Static object can be used directly at start() method for RangerHdfsAuthorizer class
Date Mon, 25 Sep 2017 14:18:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62539/#review186120
-----------------------------------------------------------


Ship it!




Ship It!

- Colm O hEigeartaigh


On Sept. 25, 2017, 11:48 a.m., wang yuan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62539/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2017, 11:48 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh,
Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and
Qiang Zhang.
> 
> 
> Bugs: RANGER-1807
>     https://issues.apache.org/jira/browse/RANGER-1807
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> At start() method for RangerHdfsAuthorizer class.
> isOptimizeSubAccessAuthEnabled() is a static method,it can used directly .
> 
> {code:title=RangerHdfsAuthorizer.java.java}
> public void start() {
> 		if(LOG.isDebugEnabled()) {
> 			LOG.debug("==> RangerHdfsAuthorizer.start()");
> 		}
> 
> 		RangerHdfsPlugin plugin = new RangerHdfsPlugin();
> 		plugin.init();
> 
> 		if (plugin.isOptimizeSubAccessAuthEnabled()) {   // if (RangerHdfsPlugin.isOptimizeSubAccessAuthEnabled())
{		
> 			... ...
> 		}
>  
>        public static boolean isOptimizeSubAccessAuthEnabled() {
> 		return RangerHdfsPlugin.optimizeSubAccessAuthEnabled;
> 	}
> {code}
> 
> 
> Diffs
> -----
> 
>   hdfs-agent/src/main/java/org/apache/ranger/authorization/hadoop/RangerHdfsAuthorizer.java
97fd5cd5 
> 
> 
> Diff: https://reviews.apache.org/r/62539/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> wang yuan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message