ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Colm O hEigeartaigh <cohei...@apache.org>
Subject Re: Review Request 62522: The exception information is error when judge password for RangerKeyStoreProvider class
Date Mon, 25 Sep 2017 14:20:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62522/#review186121
-----------------------------------------------------------



I would leave in "Master Key" to make it clearer, e.g. "The Master Key Password is empty or
not a valid password"

- Colm O hEigeartaigh


On Sept. 25, 2017, 5:47 a.m., wang yuan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62522/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2017, 5:47 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh,
Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and
Qiang Zhang.
> 
> 
> Bugs: RANGER-1804
>     https://issues.apache.org/jira/browse/RANGER-1804
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> The exception information is error when judge password for RangerKeyStoreProvider class
> I think it should throw the password is error instead of throw master key not exists.
> {code}
> String password = conf.get(ENCRYPTION_KEY);
> 		if(password == null || password.trim().equals("") || password.trim().equals("_") ||
password.trim().equals("crypted")){
> 			throw new IOException("Master Key Jceks does not exists");
> 		}
> {code}
> 
> 
> Diffs
> -----
> 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStoreProvider.java 267fcf08

> 
> 
> Diff: https://reviews.apache.org/r/62522/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> wang yuan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message